Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new mail footers to template files. #639

Merged
merged 1 commit into from
Aug 21, 2018
Merged

Add new mail footers to template files. #639

merged 1 commit into from
Aug 21, 2018

Conversation

micbar
Copy link
Contributor

@micbar micbar commented Aug 10, 2018

Fixes owncloud/enterprise#2788

Expected behaviour

Mails from the activity app should contain the new mail footer with "imprint" and "privacy policy" links.

Html Footer

<?php print_unescaped($this->inc('html.mail.footer', ['app' => 'core'])); ?>

Plain Text Footer

<?php print_unescaped($this->inc('plain.mail.footer', ['app' => 'core'])); ?>

What happens instead

The footer is missing.

Activity app didn't follow up with this change.

@codecov-io
Copy link

codecov-io commented Aug 11, 2018

Codecov Report

Merging #639 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #639   +/-   ##
=========================================
  Coverage     86.56%   86.56%           
  Complexity      495      495           
=========================================
  Files            36       36           
  Lines          1787     1787           
=========================================
  Hits           1547     1547           
  Misses          240      240

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9aac65...1d5b5e3. Read the comment docs.

@micbar micbar requested a review from VicDeo August 13, 2018 19:54
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit 887bd65 into master Aug 21, 2018
@PVince81 PVince81 deleted the add-mail-footer branch August 21, 2018 10:03
@PVince81 PVince81 mentioned this pull request Aug 23, 2018
23 tasks
@PVince81 PVince81 modified the milestones: development, QA Sep 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants