Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the time from the mail, keep the date #1118

Merged
merged 1 commit into from
Aug 30, 2022
Merged

Remove the time from the mail, keep the date #1118

merged 1 commit into from
Aug 30, 2022

Conversation

jvillafanez
Copy link
Member

Related to https://github.com/owncloud/enterprise/issues/5227

The specific time of the event won't be shown, just the date. Note that "Today", "Yesterday" or "Tomorrow" might still appear instead of the actual date.

@jvillafanez jvillafanez self-assigned this Jul 5, 2022
@CLAassistant
Copy link

CLAassistant commented Jul 5, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@jvillafanez jvillafanez force-pushed the remove_time_from_mail branch from 7537bdd to 6c50425 Compare July 18, 2022 06:54
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@jvillafanez jvillafanez force-pushed the remove_time_from_mail branch from 6c50425 to 7cc1833 Compare August 30, 2022 09:48
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@jnweiger jnweiger merged commit d466db0 into master Aug 30, 2022
@delete-merged-branch delete-merged-branch bot deleted the remove_time_from_mail branch August 30, 2022 15:18
@jnweiger jnweiger mentioned this pull request Aug 30, 2022
Closed
@jnweiger
Copy link
Contributor

Confirmed fixed. The time is actually removed from all notification mails, not only expiry mails.
That is okayish, as the mail itself still has a timestamp in the header.

"Date": "Mon, 12 Sep 2022 21:39:10 +0000",
"To": "admin <[email protected]>",
"Subj": "Activity notification",

Hello admin,

You are receiving this email because the following things happened at https://oc10110rc1-activity-271rc1-20220912.jw-qa.owncloud.works/

* You shared Documents with group admin - Today
* You created Photos/bunny.stl - Today

@jnweiger jnweiger mentioned this pull request Sep 12, 2022
Open
@pako81 pako81 mentioned this pull request Jul 4, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@AlexAndBear AlexAndBear Awaiting requested review from AlexAndBear

@JammingBen JammingBen Awaiting requested review from JammingBen

Assignees

@jvillafanez jvillafanez

Labels
3 - To review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jvillafanez @CLAassistant @jnweiger @phil-davis