Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use core acceptance-test-changes-waiting-2021-11 branch for acceptance tests #1038

Merged
merged 1 commit into from
Dec 17, 2021

Conversation

phil-davis
Copy link
Contributor

This should be the fix for issue #1037

A test change was made in core PR owncloud/core#39514 and that code is currently in core branch acceptance-test-changes-waiting-2021-11

So use that code for now.

@phil-davis phil-davis self-assigned this Dec 17, 2021
@phil-davis
Copy link
Contributor Author

Note: that core branch should be merged to core master late next week. So we will be able to revert this by Christmas, I hope.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kiranparajuli589
Copy link
Contributor

@phil-davis should we create an issue to revert this after acceptance-test-changes-waiting-2021-11?

@phil-davis
Copy link
Contributor Author

@phil-davis should we create an issue to revert this after acceptance-test-changes-waiting-2021-11?

I put a to-do in the issue #1037 and I will set that issue to "blocked"

@phil-davis phil-davis merged commit e815773 into master Dec 17, 2021
@delete-merged-branch delete-merged-branch bot deleted the use-pending-core-branch branch December 17, 2021 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants