Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose data storage port 9160 #26

Merged
merged 1 commit into from
Jun 4, 2020
Merged

Expose data storage port 9160 #26

merged 1 commit into from
Jun 4, 2020

Conversation

PVince81
Copy link
Contributor

@PVince81 PVince81 commented Jun 3, 2020

Required for TUS uploads that talk directly to the data provider

Required for TUS uploads that talk directly to the data provider
@PVince81
Copy link
Contributor Author

PVince81 commented Jun 3, 2020

This makes the call to the data provider go through instead of being stuck until timeout.

However this reveals further issues to be debugged (a 500 error in the PATCH call)

@felixboehm @butonic

@jnweiger
Copy link
Contributor

jnweiger commented Jun 3, 2020

Ah, that is why the uploads fail? 👍
Testing that extra port with owncloud-client 2.7.x daily: Yes , now the client can upload files!

Testing that extra port with the Phoenix web ui, I still seem to get

image

@jnweiger jnweiger self-requested a review June 3, 2020 13:46
Copy link
Contributor

@jnweiger jnweiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

solves upload issue with desktop client.
LGTM.

@PVince81
Copy link
Contributor Author

PVince81 commented Jun 4, 2020

note, in the future we should look into putting this behind the proxy, see owncloud/ocis-proxy#44

@jnweiger
Copy link
Contributor

jnweiger commented Jun 4, 2020

thanks for bringing up the proxy topic. We can continue that as suggested in owncloud/ocis-proxy#44 and close here.

@jnweiger jnweiger merged commit a8a7cd8 into owncloud-docker:master Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants