Skip to content
This repository has been archived by the owner on Dec 3, 2019. It is now read-only.

Move user creation logic to a separate service in core #196

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sharidas
Copy link
Contributor

Move user creation logic to a separate service in
core.

Signed-off-by: Sujith H [email protected]

@sharidas sharidas added this to the development milestone Jul 24, 2019
@sharidas sharidas self-assigned this Jul 24, 2019
@sharidas
Copy link
Contributor Author

sharidas commented Jul 24, 2019

@jvillafanez
Copy link

Update the link in the previous post because I clicked on a closed unmerged ticket

@sharidas sharidas force-pushed the move-usercreate-tocore-v2 branch from 3464be9 to d0b578e Compare August 7, 2019 13:00
@jvillafanez
Copy link

Code looks good, waiting for the test results

@sharidas
Copy link
Contributor Author

sharidas commented Aug 9, 2019

This PR is dependant on owncloud/core#35972. There is a class from the core pr being used in this change set.

Move user creation logic to a separate service in
core.

Signed-off-by: Sujith H <[email protected]>
@sharidas
Copy link
Contributor Author

Looking at the failure in the unit tests

@DeepDiver1975 It would be nice if you could share your opinion or suggestion on how to move ahead with this PR, as its user_management app.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants