This repository has been archived by the owner on Dec 3, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3
Move user creation logic to a separate service in core #196
Open
sharidas
wants to merge
1
commit into
master
Choose a base branch
from
move-usercreate-tocore-v2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
sharidas
force-pushed
the
move-usercreate-tocore-v2
branch
from
July 29, 2019 06:42
ee1f60d
to
3464be9
Compare
12 tasks
jvillafanez
reviewed
Aug 7, 2019
Update the link in the previous post because I clicked on a closed unmerged ticket |
sharidas
force-pushed
the
move-usercreate-tocore-v2
branch
from
August 7, 2019 13:00
3464be9
to
d0b578e
Compare
Code looks good, waiting for the test results |
This PR is dependant on owncloud/core#35972. There is a class from the core pr being used in this change set. |
Move user creation logic to a separate service in core. Signed-off-by: Sujith H <[email protected]>
sharidas
force-pushed
the
move-usercreate-tocore-v2
branch
from
August 13, 2019 06:33
d0b578e
to
f3358e1
Compare
Looking at the failure in the unit tests
@DeepDiver1975 It would be nice if you could share your opinion or suggestion on how to move ahead with this PR, as its user_management app. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move user creation logic to a separate service in
core.
Signed-off-by: Sujith H [email protected]