Adding support to .env file #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| try { | ||
| final Map<String, Integer> concurrency = ConcurrencyFlagParser.parse(flagConcurrency); | ||
| final Procfile pf = Procfile.read(path); | ||
| new ProcessManager().start(pf, process, concurrency, flagPort); | ||
| final Environment env = Environment.read(envPath); |
There was a problem hiding this comment.
I think we should ignore the .env file if it doesn't exist instead of throwing exception. That's how foreman or forego work.
|
Alright, so I just swallow the exception and return an empty environment if I can't find the .env file. Is that good? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is very interesting for development environments to be able to use local .env files that hold environment variables that will be used by gaffer.
Tried adding it in. The tests are not fantastic and I hope to make them better if you can provide me with some guidance around what you're looking for.