Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use os.MkdirTemp instead of ioutil.TempDir #123

Merged
merged 5 commits into from
Nov 24, 2024

Conversation

atombrella
Copy link
Contributor

@atombrella atombrella commented Nov 8, 2024

📑 Description

  • Replaced deprecated library function in a test util file.
  • Added make quality to the build CI pipeline to guard against future lint failures

I have added a .golangci configuration file, but silenced a few matches from gocritic. One of them is hugeParam which yields a few matches. Maybe it's worth looking into. exitAfterDefer has a single match, but in the starter-function for the tests.

I'm a bit fed up with spam caused by leaving my email address in git commits, hence the anonymous address.

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

I opened various files in VSCode and hit save. It does "golang import-style" as well as go-formatting when doing so.

@atombrella
Copy link
Contributor Author

@owenrumney Is there something I need to do?

@owenrumney
Copy link
Owner

@owenrumney Is there something I need to do?

Hey @atombrella - it's been a while! 👋

Nope, all good, I just didn't see this PR - ✅

@atombrella
Copy link
Contributor Author

atombrella commented Nov 23, 2024

@owenrumney I don't have merge rights :) I see that there's something odd with go.mod. There are also two PRs from dependabot.

Cheers :)

atombrella and others added 5 commits November 24, 2024 13:04
using vendor dir, probably should have done this in the first place
some fixes based on the output from make quality
@owenrumney owenrumney merged commit 07378a3 into owenrumney:main Nov 24, 2024
1 check passed
@atombrella atombrella deleted the fix/ioutil branch November 24, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants