chore: update to latest final 2.1.0 #69
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christopher Phillips <[email protected]>
Signed-off-by: Christopher Phillips <[email protected]>
|
Also happy to update the URL to any other one you might deem more appropriate =) |
|
@owenrumney Let me know if there is anything else you need for this PR - happy to make any changes or updates! |
|
Thanks for this @spiffcs - I wonder if we should use |
|
thanks - I can't push to your branch but I've used the commits and used the oasis-open URL in #71 |
|
Thanks @owenrumney - sorry for missing the follow up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Description
It looks like the 2.1.0 schema was finalized and exists here.
Documents generated with
go-sarifusing the old schemartmin the schema field will fail Microsoft's schema validation found here:https://sarifweb.azurewebsites.net/
The diff between
rtmandmainis immaterial and only consists of description updates.This change should make the schema field of the generated document valid with upstream tooling =)
✅ Checks
ℹ Additional Information