Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set define auditExclude in config #637

Closed
wants to merge 4 commits into from

Conversation

ShahbozHalim
Copy link

No description provided.

@ShahbozHalim ShahbozHalim changed the title set define audit_exclude set define auditExclude in config Mar 17, 2021
@MortenDHansen MortenDHansen added enhancement An improvement or new feature v12 labels Feb 2, 2022
@MortenDHansen MortenDHansen self-assigned this Feb 2, 2022
@MortenDHansen
Copy link
Contributor

Thanks for the contribution! - we will merge it, but i'm just considering how this would work the best

  • As suggested here, it will work like "audit_exclude_defaults". If nothing is defined, it will take these values.
  • Maybe it would be better if it works like a merge so that it merges the global excludes with model specific excludes.
  • Finally it could be default excludes which can be overwritten on a model level. (which would require to make it possible to opt out of excludes like with eloquents $guarded = [] array

MortenDHansen added a commit that referenced this pull request Feb 11, 2022
@MortenDHansen
Copy link
Contributor

Needed to refactor the exclusion logic to make it play nice with local overrides. It will be included with the v13 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion enhancement An improvement or new feature v12
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants