Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flip allocations that happen during initialization (typically) over to u... #618

Conversation

thehelix112
Copy link

This moves allocations that happen during startup to always happen in directory_config (or derived) apr memory pools.
Some interface changes were required.

Make check still passes on ubuntu 12.04, gcc 4.6, x86_64:

All tests passed (577).
PASS: run-unit-tests.pl
=============
1 test passed
=============

@zimmerle
Copy link
Contributor

Created an branch under ModSecurity's tree (https://github.com/SpiderLabs/ModSecurity/tree/thehelix112-allocate_in_directory_config_p)

Experimental Buildbots are performing compilation and tests. Lets wait for the results.

@thehelix112
Copy link
Author

Cool. Are the buildbots internal to trustwave, or can I follow progress somewhere?

@thehelix112
Copy link
Author

Hey Filipe,

Any progress with this pull-request? Is there anything that I need to address or improve?
Thanks,

Dave

@zimmerle
Copy link
Contributor

zimmerle commented Mar 3, 2014

Hi @thehelix112 thanks for the patch it just got merge into our master tree. This will be very important for us in oder to better handle our memory management, that initial organization will be important. Thanks.

@zimmerle zimmerle closed this Mar 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants