Fix invalid storage reference in getkey() #609
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when creating a string from salt[]. salt[] is not
'\0'-terminated, so apr_psprintf() needs to be told
the extent of the bytes to read.
It is easy to test old/new code standalone with valgrind;
jst insert the getkey() function into this template:
-----------getkey() goes here-----------------
int main(void)
{
apr_pool_t *p;
apr_initialize();
apr_pool_create(&p, NULL);
printf("%s\n", getkey(p));
return 0;
}
|
Hi @trawick, Bug is confirmed. I've made some comments on your commit. Thanks for the merge request. |
|
Hi @trawick, are you still working on this? |
zimmerle
force-pushed
the
master
branch
2 times, most recently
from
e516f4c to
84f2299
Compare
zimmerle
pushed a commit
that referenced
this pull request
Apr 6, 2015
|
Merged the original request plus some updates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix invalid storage reference by apr_psprintf() when creating a string from salt[]. salt[] is not
'\0'-terminated, so apr_psprintf() needs to be told the extent of the bytes to read.
It is easy to test old/new code standalone with valgrind; just insert the getkey() function into this template:
include <stdio.h>
include "apr_general.h"
include "apr_strings.h"
include "apr_base64.h"
include "apr_sha1.h"
int main(void)
{
apr_pool_t *p;
}