Use pkg-config to find libxml2, falling back to xml2-config if necessary #2714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughmcmaster
changed the title
Debian is taking steps to remove xml2-config in favour of pkg-config. This means ModSecurity will build without libxml2 support by default on Debian, Ubuntu and other distributions tracking Debian packages. This patch modifies build/libxml.m4 to check for libxml2 via pkg-config, falling back to xml2-config if necessary.
|
Hi @martinhsv, hoping you can look at this MR soon. Debian goes into freeze in January... |
|
Hello @hughmcmaster , I wasn't aware of Debian's plan re: xml2-config. Thanks for both raising the issue and submitting the PR. I'll plan to merge this shortly. In our other maintained branch (v2/master), it looks to me like the same issue applies in the comparable file (find_xml.m4). Would you be interested in submitting a pull request to update that one as well? (No obligation, of course.) |
|
Thanks, @martinhsv. I'm happy to send a patch for the other branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debian is taking steps to remove
xml2-configin favour ofpkg-config. This means ModSecurity will build without libxml2 support by default on Debian, Ubuntu and other distributions tracking Debian packages.This patch modifies
build/libxml.m4to check for libxml2 viapkg-config, falling back toxml2-configif necessary.