Confusing variable name in setRequestBody method #2635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @Mesar-Ali , If we are to make this change, https_client.h should probably also be modified to have the changed name in the function prototype. Would you like to do that and adjust this pull request? |
|
Thanks @martinhsv |
|
Merged. Thanks @Mesar-Ali |
martinhsv
added a commit
that referenced
this pull request
Dec 30, 2021
|
@martinhsv Thanks for merging, but info added to release notes looks incorrect here |
|
Yes, I realized the error almost immediately and corrected it. Thanks. |
vladbukin
pushed a commit
to vladbukin/ModSecurity
that referenced
this pull request
Apr 12, 2022
daixiang0
pushed a commit
to daixiang0/ModSecurity
that referenced
this pull request
Apr 24, 2022
leyao-daily
pushed a commit
to leyao-daily/ModSecurity
that referenced
this pull request
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 2 methods,
setRequestBody()andsetRequestType()argument variable name is same in both, that is
requestTypefor better code readability, it should be
requestBodyforsetRequestBody()