Two small configure fixes #1158
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The find_curl macro is also checking whether libcurl is linked against gnutls. However the check depends on "CURL_LIBS" which wasn't defined by the macro. This commit will define "CURL_LIBS" so that the check works as expected.
Macros like "find_curl" are using "verbose_output" variable but because some of them are called before we define the variable we are seeing errors like ./configure: line 13855: test: : integer expression expected This commit will fix the problem by moving the "verbose_output" declaration up to the beginning so that the variable is available for every macro.
|
Hi @Whissi, Thank you for the patch! I will be looking at it. |
zimmerle
added a commit
that referenced
this pull request
Jun 14, 2016
|
Hi @Whissi, Your patch has being merged to our master branch, it will be part of our next release. Thank you. |
mkubenka
pushed a commit
to mkubenka/ModSecurity
that referenced
this pull request
Aug 11, 2016
mkubenka
pushed a commit
to mkubenka/ModSecurity
that referenced
this pull request
Aug 11, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see the following two small fixes for the configure script. For details please the particular commit message.