Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make url path absolute for SecHashEngine only when it is relative in the first place. Fix #752 #1071

Closed

Conversation

hideaki
Copy link
Contributor

@hideaki hideaki commented Feb 5, 2016

No description provided.

@zimmerle zimmerle added this to the v2.9.2 milestone Apr 5, 2016
@zimmerle
Copy link
Contributor

Hi @hideaki,

Sorry for the long delay. That seems to be an interesting feature, however we also understand the value of having a relative path. What do you think about having the fixed path as a configuration option?

@zimmerle zimmerle self-assigned this Jul 11, 2016
@hideaki
Copy link
Contributor Author

hideaki commented Oct 21, 2016

Hi @zimmerle,
This is a bug fix for #752, rather than a feature.
As per my observation and understanding, SecHashEngine today always turns paths into absolute. It even tries to absolutize already absolute path, and that is resulting in broken paths, which is #752.
This fix is about avoiding the double-absolutization by absolutizing the path only when it is still relative.

Having said that, config for keeping relative path relative sounds like a good idea to me.

@zimmerle zimmerle self-requested a review May 22, 2017 21:58
zimmerle pushed a commit that referenced this pull request May 22, 2017
@zimmerle
Copy link
Contributor

Merged thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants