Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to install ModSecurity on Windows Server 2016 #931

Closed
skvoboo opened this issue Sep 21, 2015 · 13 comments
Closed

Unable to install ModSecurity on Windows Server 2016 #931

skvoboo opened this issue Sep 21, 2015 · 13 comments
Assignees
Milestone

Comments

@skvoboo
Copy link

skvoboo commented Sep 21, 2015

Unable to install ModSecurity 2.9.0 on Windows Server 2016 technical preview 3 (IIS 10) : This setup requires IIS 7.0 or 8.0.

Please change LaunchCondition in installer from
(IIS="#7") OR (IIS="#8")
to
(IIS="#7") OR (IIS="#8") OR (IIS="#10")

@zimmerle
Copy link
Contributor

Hi @skvoboo did you tested 2.9.0 on 2016? is it working right?

zimmerle pushed a commit that referenced this issue Sep 28, 2015
As reported on issue #931 the installer was marking ModSecurity as incompatible
with IIS 10.
@zimmerle
Copy link
Contributor

Fix on branch:

https://github.com/SpiderLabs/ModSecurity/tree/issue_931

Waiting for confirmation that ModSecurity really working with IIS 10.

@zimmerle zimmerle self-assigned this Sep 28, 2015
@pvasilevich
Copy link

Are there any news on this patch? when it will be merged in master?

@zimmerle
Copy link
Contributor

Hi @pvasilevich,

It won't be merged until we got the confirmation that it is really working. Do you mind to test it?

This specific patch only adds the IIS 10 as accepted on the installer validation.

@pvasilevich
Copy link

It is pretty hard to test how Modsecurity is working without ability to install it. I can manually apply MSI transformation, but I guess there will be more chances to find bugs on this platform, if other people will be able to install Modsecurity as well.

I will check basic functionality anyway and report you if there are other issues.

@csanders-git
Copy link

@pvasilevich I wanted to confirm you're running technical preview 3.. is this correct?

@pvasilevich
Copy link

Now we are testing on tech preview 4

@csanders-git
Copy link

@pvasilevich A quick way to test the install is to change (temporarily) "HKLM\SOFTWARE\Microsoft\InetStp" from 10 to 8 then after install change back.

@csanders-git
Copy link

From initial tests it seems to be working fine. I will conduct more through tests....
image

@zimmerle zimmerle modified the milestones: v3.0.0, v2.9.1 Dec 15, 2015
@zimmerle
Copy link
Contributor

Hi @csanders-git,

That was a beautiful hack 👍

I guess it is safe to merge to our mainline.

Thank you guys.

@zimmerle
Copy link
Contributor

@skvoboo what is your full name?

I want to mention your name on the changelogs.

@skvoboo
Copy link
Author

skvoboo commented Dec 16, 2015

Hi @zimmerle. My full name is Anton Serbulov.

zimmerle pushed a commit that referenced this issue Jan 4, 2016
As reported on issue #931 the installer was marking ModSecurity as incompatible
with IIS 10.
@zimmerle
Copy link
Contributor

zimmerle commented Jan 4, 2016

Thank you guys, the patch was merged. ModSecurity v2.9.1 will be compatible with IIS 10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants