Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leak in intervention processing #100

Closed
wants to merge 5 commits into from
Closed

Fix memory leak in intervention processing #100

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
312f029
Updates the CHANGES files
Dec 20, 2017
934fb69
Merge remote-tracking branch 'upstream/master'
defanator Dec 25, 2017
76677cc
Merge remote-tracking branch 'upstream/master'
defanator Mar 21, 2018
6b87286
Merge remote-tracking branch 'upstream/master'
defanator Apr 4, 2018
077d44c
Fix memory leak in intervention processing
defanator Apr 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/ngx_http_modsecurity_module.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,7 @@ ngx_inline char *ngx_str_to_char(ngx_str_t a, ngx_pool_t *p)
ngx_inline int
ngx_http_modsecurity_process_intervention (Transaction *transaction, ngx_http_request_t *r)
{
char *log = NULL;
ModSecurityIntervention intervention;
intervention.status = 200;
intervention.url = NULL;
Expand All @@ -145,11 +146,16 @@ ngx_http_modsecurity_process_intervention (Transaction *transaction, ngx_http_re
return 0;
}

log = intervention.log;
if (intervention.log == NULL) {
intervention.log = "(no log message was specified)";
log = "(no log message was specified)";
}

ngx_log_error(NGX_LOG_WARN, (ngx_log_t *)r->connection->log, 0, "%s", intervention.log);
ngx_log_error(NGX_LOG_WARN, (ngx_log_t *)r->connection->log, 0, "%s", log);

if (intervention.log != NULL) {
free(intervention.log);
}

if (intervention.url != NULL)
{
Expand Down