UDN: Patch Kubevirt CR to support managedTap binding #4773

oshoval · 2024-10-13T09:32:27Z

What this PR does and why is it needed

Use managedTap instead passt for UDN

Which issue(s) this PR fixes

Fixes #

Special notes for reviewers

How to verify it

Details to documentation updates

Description for the changelog

Does this PR introduce a user-facing change?

None

maiqueb

you only need one in upstream OVN-K, right ?

oshoval · 2024-10-14T09:39:12Z

True, i just wanted to do it smoother, i.e that as long as IPAM repo is not updated, it wont break it
(we can make the change there first if you prefer and drop in this PR)

maiqueb · 2024-10-14T09:50:40Z

True, i just wanted to do it smoother, i.e that as long as IPAM repo is not updated, it wont break it (we can make the change there first if you prefer and drop in this PR)

Whatever is both conceptually correct and simpler for you.

oshoval · 2024-10-14T13:19:06Z

Removed the passt here - going to test it on the dummy PR oshoval#3

also added the PR for IPAM that works on CI as well kubevirt/ipam-extensions#73

oshoval · 2024-10-27T11:40:10Z

injected to use nightly
lets see all pass (and then we can remove it)

oshoval · 2024-10-27T13:40:27Z

either i did something wrong or the managedTap is broken on nightly kubevirt
will check (worked 2 weeks ago, before PR were merged, while compiled locally)
https://github.com/ovn-org/ovn-kubernetes/actions/runs/11540164957/job/32121009180?pr=4773

oshoval · 2024-10-27T14:10:12Z

added new required FG, lets see it works

oshoval · 2024-10-27T15:15:10Z

Hi Miguel, please disregard the re-review request, we need anyhow first to discuss offline about generic name and such

oshoval · 2024-10-28T10:49:40Z

contrib/kind-common

@@ -328,6 +328,8 @@ install_kubevirt() {
    # nightly tag - install specific nightly (i.e 20240910)
    KUBEVIRT_VERSION=${KUBEVIRT_VERSION:-"stable"}

+    KUBEVIRT_VERSION=nightly


well we would need to consume nightly or to release kubevirt or to pin it to one that has all the required code
but for sure can make it on its own commit nicely

oshoval · 2024-10-28T10:56:42Z

failures are not related, the UDN ones passed

maiqueb

Some questions.

contrib/kind-common

test/e2e/kubevirt.go

oshoval · 2024-10-29T11:40:44Z

Updated as we spoke offline
CR support both
e2e tests here runs mangedTap

Note please the 3rd commit, if we dont want nightly because it might break OVN if kubevirt breaks,
we can pin specific nightly meanwhile 20241029 or ask for a stable but it might take time and we would be block until that if we do.

qinqon

Looks good as far as CI is happy.

qinqon · 2024-10-29T11:42:14Z

contrib/kind-common

@@ -326,7 +326,7 @@ install_kubevirt() {
    # vX.Y.Z - install specific stable (i.e v1.3.1)
    # nightly - install newest nightly
    # nightly tag - install specific nightly (i.e 20240910)
-    KUBEVIRT_VERSION=${KUBEVIRT_VERSION:-"stable"}
+    KUBEVIRT_VERSION=${KUBEVIRT_VERSION:-"nightly"}


Should we wait for a kubevirt release ?

it will ask if a special one can be created but i doubt as the minor should change maybe,
will also ask when the stable is out, it might take time

imho we can use 20241029, it is safer, see please
#4773 (comment)
we will just need to update once there is a stable and wont be blocked
but your call

https://github.com/kubevirt/sig-release/blob/main/releases/v1.4/schedule.md
lets wait, rc should be any day
iiuc it will appear on https://storage.googleapis.com/kubevirt-prow/release/kubevirt/kubevirt/stable.txt that we use by default

disregard, stable.txt wont have it, checking about alternatives (i.e new file on that path etc)

To make this clear: this is the only thing holding this PR. I.e. we want to pin a 1.4 RC version.

Right ?

test/e2e/kubevirt.go

maiqueb

Let's pin a KubeVirt 1.4 RC version (which is not available yet ... should be imminent).

maiqueb · 2024-10-31T15:12:29Z

contrib/kind-common

@@ -326,7 +326,7 @@ install_kubevirt() {
    # vX.Y.Z - install specific stable (i.e v1.3.1)
    # nightly - install newest nightly
    # nightly tag - install specific nightly (i.e 20240910)
-    KUBEVIRT_VERSION=${KUBEVIRT_VERSION:-"stable"}
+    KUBEVIRT_VERSION=${KUBEVIRT_VERSION:-"nightly"}


To make this clear: this is the only thing holding this PR. I.e. we want to pin a 1.4 RC version.

Right ?

contrib/kind-common

test/e2e/kubevirt.go

oshoval · 2024-11-03T14:23:17Z

Updated to use v1.4.0-rc.0

oshoval · 2024-11-03T14:23:54Z

rebased

qinqon

/lgtm

maiqueb

Tks.

@tssurya could you take a look ? We are registering the new binding (that allows live migration) in KubeVirt.

We are keeping the other around because we have people working on improving it (the long term plan is to use it).

oshoval · 2024-11-13T14:48:32Z

contrib/kind-common

@@ -326,7 +326,7 @@ install_kubevirt() {
    # vX.Y.Z - install specific stable (i.e v1.3.1)
    # nightly - install newest nightly
    # nightly tag - install specific nightly (i.e 20240910)
-    KUBEVIRT_VERSION=${KUBEVIRT_VERSION:-"stable"}
+    KUBEVIRT_VERSION=${KUBEVIRT_VERSION:-"v1.4.0-rc.0"}


1.4.0 is out, so i will first change to use stable as always
EDIT - done

Signed-off-by: Or Shoval <[email protected]>

Since hostname is populated now via DHCP, we can always use the vmi name in the console expecter. Signed-off-by: Or Shoval <[email protected]>

oshoval · 2024-11-13T14:50:50Z

changes
stick to use stable instead #4773 (comment)
because it was released and has the required code

rebased

oshoval mentioned this pull request Oct 13, 2024

DMM Test TAP oshoval/ovn-kubernetes#3

Closed

github-actions bot added area/e2e-testing feature/kubevirt-live-migration All issues related to kubevirt live migration labels Oct 14, 2024

maiqueb requested changes Oct 14, 2024

View reviewed changes

oshoval force-pushed the mantap branch from 9796e8b to a130554 Compare October 14, 2024 13:18

oshoval force-pushed the mantap branch from a130554 to 2a7c604 Compare October 27, 2024 11:39

oshoval changed the title ~~UDN: Patch Kubevirt CR to support managedTap binding~~ WIP UDN: Patch Kubevirt CR to support managedTap binding Oct 27, 2024

oshoval force-pushed the mantap branch from 2a7c604 to 8ae2809 Compare October 27, 2024 14:03

oshoval mentioned this pull request Oct 27, 2024

UDN: Use managedTap instead passt kubevirt/ipam-extensions#73

Merged

oshoval requested a review from maiqueb October 27, 2024 15:13

oshoval commented Oct 28, 2024

View reviewed changes

oshoval changed the title ~~WIP UDN: Patch Kubevirt CR to support managedTap binding~~ UDN: Patch Kubevirt CR to support managedTap binding Oct 29, 2024

oshoval marked this pull request as ready for review October 29, 2024 10:19

oshoval requested a review from a team as a code owner October 29, 2024 10:19

maiqueb reviewed Oct 29, 2024

View reviewed changes

contrib/kind-common Show resolved Hide resolved

test/e2e/kubevirt.go Show resolved Hide resolved

oshoval force-pushed the mantap branch from 8ae2809 to 0920420 Compare October 29, 2024 11:38

qinqon approved these changes Oct 29, 2024

View reviewed changes

maiqueb requested changes Oct 31, 2024

View reviewed changes

oshoval force-pushed the mantap branch from 0920420 to 8801783 Compare November 3, 2024 14:22

oshoval requested a review from maiqueb November 3, 2024 14:23

oshoval force-pushed the mantap branch from 8801783 to ab38f58 Compare November 3, 2024 14:23

qinqon approved these changes Nov 4, 2024

View reviewed changes

maiqueb previously approved these changes Nov 4, 2024

View reviewed changes

qinqon mentioned this pull request Nov 13, 2024

kubevirt, e2e, udn: Add north south traffic and tcp connection checks for e/w and n/s. #4834

Open

10 tasks

oshoval commented Nov 13, 2024

View reviewed changes

oshoval added 2 commits November 13, 2024 16:50

UDN: Patch Kubevirt CR to support managedTap binding

debbd1f

Signed-off-by: Or Shoval <[email protected]>

UDN: Adapt tests to use managedTap instead passt

5c674d9

Since hostname is populated now via DHCP, we can always use the vmi name in the console expecter. Signed-off-by: Or Shoval <[email protected]>

oshoval dismissed maiqueb’s stale review via 0d83af0 November 13, 2024 14:50

oshoval force-pushed the mantap branch from ab38f58 to 0d83af0 Compare November 13, 2024 14:50

oshoval requested a review from a team as a code owner November 13, 2024 14:50

oshoval requested a review from trozet November 13, 2024 14:50

oshoval force-pushed the mantap branch from 0d83af0 to 5c674d9 Compare November 13, 2024 14:50

oshoval requested review from qinqon and maiqueb November 13, 2024 14:51

trozet approved these changes Nov 14, 2024

View reviewed changes

trozet merged commit 7b50659 into ovn-kubernetes:master Nov 14, 2024
37 of 40 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

UDN: Patch Kubevirt CR to support managedTap binding #4773

UDN: Patch Kubevirt CR to support managedTap binding #4773

oshoval commented Oct 13, 2024 •

edited

Loading

maiqueb left a comment

oshoval commented Oct 14, 2024 •

edited

Loading

maiqueb commented Oct 14, 2024

oshoval commented Oct 14, 2024 •

edited

Loading

oshoval commented Oct 27, 2024

oshoval commented Oct 27, 2024 •

edited

Loading

oshoval commented Oct 27, 2024

oshoval commented Oct 27, 2024

oshoval Oct 28, 2024 •

edited

Loading

oshoval commented Oct 28, 2024

maiqueb left a comment

oshoval commented Oct 29, 2024

qinqon left a comment

qinqon Oct 29, 2024

oshoval Oct 29, 2024

oshoval Oct 29, 2024 •

edited

Loading

oshoval Oct 29, 2024

maiqueb Oct 31, 2024

oshoval Oct 31, 2024

maiqueb left a comment

maiqueb Oct 31, 2024

oshoval commented Nov 3, 2024

oshoval commented Nov 3, 2024

qinqon left a comment

maiqueb left a comment

oshoval Nov 13, 2024 •

edited

Loading

oshoval commented Nov 13, 2024

UDN: Patch Kubevirt CR to support managedTap binding #4773

UDN: Patch Kubevirt CR to support managedTap binding #4773

Conversation

oshoval commented Oct 13, 2024 • edited Loading

What this PR does and why is it needed

Which issue(s) this PR fixes

Special notes for reviewers

How to verify it

Details to documentation updates

Description for the changelog

Does this PR introduce a user-facing change?

maiqueb left a comment

Choose a reason for hiding this comment

oshoval commented Oct 14, 2024 • edited Loading

maiqueb commented Oct 14, 2024

oshoval commented Oct 14, 2024 • edited Loading

oshoval commented Oct 27, 2024

oshoval commented Oct 27, 2024 • edited Loading

oshoval commented Oct 27, 2024

oshoval commented Oct 27, 2024

oshoval Oct 28, 2024 • edited Loading

Choose a reason for hiding this comment

oshoval commented Oct 28, 2024

maiqueb left a comment

Choose a reason for hiding this comment

oshoval commented Oct 29, 2024

qinqon left a comment

Choose a reason for hiding this comment

qinqon Oct 29, 2024

Choose a reason for hiding this comment

oshoval Oct 29, 2024

Choose a reason for hiding this comment

oshoval Oct 29, 2024 • edited Loading

Choose a reason for hiding this comment

oshoval Oct 29, 2024

Choose a reason for hiding this comment

maiqueb Oct 31, 2024

Choose a reason for hiding this comment

oshoval Oct 31, 2024

Choose a reason for hiding this comment

maiqueb left a comment

Choose a reason for hiding this comment

maiqueb Oct 31, 2024

Choose a reason for hiding this comment

oshoval commented Nov 3, 2024

oshoval commented Nov 3, 2024

qinqon left a comment

Choose a reason for hiding this comment

maiqueb left a comment

Choose a reason for hiding this comment

oshoval Nov 13, 2024 • edited Loading

Choose a reason for hiding this comment

oshoval commented Nov 13, 2024

oshoval commented Oct 13, 2024 •

edited

Loading

oshoval commented Oct 14, 2024 •

edited

Loading

oshoval commented Oct 14, 2024 •

edited

Loading

oshoval commented Oct 27, 2024 •

edited

Loading

oshoval Oct 28, 2024 •

edited

Loading

oshoval Oct 29, 2024 •

edited

Loading

oshoval Nov 13, 2024 •

edited

Loading