Invert CNI result order for UDN

[trozet]

Makes crio happy

[trozet]

network segmentation e2es wont pass until we have the multus fix

[tssurya]

@dougbtv @maiqueb do either of you know which Multus fix @trozet is talking about here? Trying to keep things moving...

[maiqueb]

@dougbtv @maiqueb do either of you know which Multus fix @trozet is talking about here? Trying to keep things moving...

I'll add these unit tests tomorrow.

Yes; this is the PR: k8snetworkplumbingwg/network-attachment-definition-client#73

We'll need afterwards to update the vendored library in multus.

[maiqueb]

There's a typo in the variable name, plus, we got to keep the comments updated - or delete them.

Code-wise, looks good.

[tssurya]

I can push for the reviewed comments do you have the unit tests ready? if so I can combine that commit in here as well

[maiqueb]

I can push for the reviewed comments do you have the unit tests ready? if so I can combine that commit in here as well

I spoke too soon; the unit tests were already adapted in this PR, Tim had done them.

There's no need to add more.

One extra thing @tssurya: you need to adjust the version of multus we are using: https://github.com/ovn-org/ovn-kubernetes/blob/93dbdf49f755472a62f64e6b5111d1801078de05/contrib/kind-common#L405

For that, Doug needs to merge the multus vendored status generation library, and create a new tag.

[dougbtv]

New Multus tag @ https://github.com/k8snetworkplumbingwg/multus-cni/releases/tag/v4.1.3 thanks!

[tssurya]

@dougbtv shall we also prepare the bump for downstream multus? not sure where we do that today...

[qinqon]

I see that all the comments from @maiqueb are addressed so this lookgs good to me.

[tssurya]

https://github.com/ovn-org/ovn-kubernetes/actions/runs/11438299020/job/31820962325?pr=4770 is likely due to #4783 but don't have time to cross check, let's see if CI turns green