[th/github-action-no-push] github: don't push test image for pull requests #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull requests don't have access to the quay secrets, this thus fails for certain users (or if the pull request originates from another repository, that is not quite clear to me). Don't push the result, just build it.
thom311
force-pushed
the
th/github-action-no-push
branch
from
35db82a to
7673d4d
Compare
|
@wizhaoredhat is it possible for us to add credentials for the quay repo to our github? Otherwise we can just stop build on PR, and just build on merges |
|
I think this is ok. LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull requests don't have access to the quay secrets, this thus fails for certain users (or if the pull request originates from another repository, that is not quite clear to me).
Don't push the result, just build it.
Note how various the open pull requests have this task failed.