Cumulative lint #24
Merged
Cumulative lint #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zinkelburger <[email protected]>
Signed-off-by: Zinkelburger <[email protected]>
Signed-off-by: Zinkelburger <[email protected]>
Signed-off-by: Zinkelburger <[email protected]>
Signed-off-by: Zinkelburger <[email protected]>
Signed-off-by: Zinkelburger <[email protected]>
Signed-off-by: Zinkelburger <[email protected]>
Signed-off-by: Zinkelburger <[email protected]>
- Add tests for evaluator.py, common.py - Add github workflows to run `mypy`, `black`, `pytest` Signed-off-by: Zinkelburger <[email protected]>
Signed-off-by: Zinkelburger <[email protected]>
Signed-off-by: Zinkelburger <[email protected]>
Signed-off-by: Zinkelburger <[email protected]>
Signed-off-by: Zinkelburger <[email protected]>
Signed-off-by: Zinkelburger <[email protected]>
Signed-off-by: Zinkelburger <[email protected]>
Signed-off-by: Zinkelburger <[email protected]>
Signed-off-by: Zinkelburger <[email protected]>
- also make self.template_args["args"] a string on line 62 of iperf.py - I did a unit test to confirm the resulting output is the same, with and without a string Signed-off-by: Zinkelburger <[email protected]>
Signed-off-by: Zinkelburger <[email protected]>
Signed-off-by: Zinkelburger <[email protected]>
Zinkelburger
force-pushed
the
cumulative_lint
branch
3 times, most recently
from
2dadf21 to
bcfb031
Compare
Signed-off-by: Zinkelburger <[email protected]>
Zinkelburger
force-pushed
the
cumulative_lint
branch
from
b503d7b to
31b4413
Compare
Closed
SalDaniele
reviewed
Apr 29, 2024
SalDaniele
reviewed
Apr 29, 2024
SalDaniele
reviewed
Apr 29, 2024
|
LGTM, a couple nits, just ping me when this is ready to merge |
Zinkelburger
force-pushed
the
cumulative_lint
branch
5 times, most recently
from
822b67e to
6e831f8
Compare
Signed-off-by: Zinkelburger <[email protected]>
Zinkelburger
force-pushed
the
cumulative_lint
branch
from
f75bef5 to
d78ff0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cumulative lint, including changes from my unmerged PRs.
Cherry picked commits from my other lint branch. I believed I have removed most of the conflicting commits.
I'm here Monday/Tuesday, so I'll continue to clean it up .
I still have some suggestions from Thomas to address, but I was able to run this successfully on 227.
The only change I'm really concerned about is making template_args["args"] equal to a string instead of a list. I did test it (and unit test it), but I feel like if this was a breaking change it'd be a headache to discover it.