[th/skip-deprecated-aliases-for-test-cases] handle aliases for test cases by skipping #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thom311
force-pushed
the
th/skip-deprecated-aliases-for-test-cases
branch
from
6a1e854 to
f6c2639
Compare
|
I think it would be cleaner to just remove those that don't work or doesn't make sense |
thom311
force-pushed
the
th/skip-deprecated-aliases-for-test-cases
branch
from
f6c2639 to
45e3237
Compare
A few TestCaseType exhibit the identical behavior as some others. We can
see that, because their TestCaseTypInfo contains the identical settings.
We also have a unit test that uncovers this ("identical_cases") and
which guards against adding such duplicate tests in the future.
Add a flag TestCaseTypInfo.deprecated_alias_for to those duplicated.
Later, we will treat them special.
Signed-off-by: Thomas Haller <[email protected]>
Some TestCaseType are identical to others. It makes no sense to run them. However, we get them easily when specifying a range or "*". If we have such a deprecated alias, then skip it if-and-only-if the original value is also present. Note that this skipping does not cover any further check for duplicates. With ranges, we can easily specify the same test multiple times, and we will run them. We only skip the aliases if the orignal is already selected. Signed-off-by: Thomas Haller <[email protected]>
Those values are basically the same as another one, respectively. They
are redundant.
Drop them.
This obviously changes behavior. It also will break existing
configurations, if they refer to one of those removed types (either by
enum name or number). However, note that ranges ("1-20") or the whole
range ("*") will still work (excluding the deleted types).
Signed-off-by: Thomas Haller <[email protected]>
thom311
force-pushed
the
th/skip-deprecated-aliases-for-test-cases
branch
from
45e3237 to
51f6243
Compare
ok, how about this? the two earlier commits are still there, they don't hurt and show how this could have been handled alternatively. I don't mind squashing the branch, if we agree on dropping the values. |
|
LGTM! Thanks for cleaning this up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some
TestCaseTypeare identical to others. If we select a range (test_cases: "*"ortest_cases: "1-26"), we will effectively run the same test twice. That is undesirable because it wastes time.Skip those aliases.
An alternative would be to just delete them. But that might break existing configurations. So it's not done (for now).