[th/ocp-tft-image-update] github: update tft-test-image container URL after migration #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The repository migrated, so the tag/URL of the container needs to be adjusted. Also, in the github workflow don't detect the "owner" via a separate build step. Other places in the repository also hard code the actual URL, so if we ever move it again, we anyway have to update those places. Having the owner part detected makes it harder to understand which tag will be used. Signed-off-by: Thomas Haller <[email protected]>
thom311
force-pushed
the
th/ocp-tft-image-update
branch
from
e728ff2 to
dd31d02
Compare
|
LGTM. Let's merge this and see if the post hooks pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The repository migrated, so the tag/URL of the container needs to be adjusted.
Also, in the github workflow don't detect the "owner" via a separate build step. Other places in the repository also hard code the actual URL, so if we ever move it again, we anyway have to update those places. Having the owner part detected makes it harder to understand which tag will be used.
I didn't actually test this, because the image will only be rebuild when the patch gets merged to
main. Please extra careful review.