[th/ocp-rename] rename various "ocp-{tft,traffic-flow-tests}" names #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thom311
force-pushed
the
th/ocp-rename
branch
from
236bada to
703e889
Compare
This is no longer necessary. ktoolbox is installed as a pip module in the virtual environment. Signed-off-by: Thomas Haller <[email protected]>
The project was renamed, so "ocp-tft*" is no longer a good name. Rename to "ktoolbox-netdev", which is what it really is. Signed-off-by: Thomas Haller <[email protected]>
Signed-off-by: Thomas Haller <[email protected]>
Signed-off-by: Thomas Haller <[email protected]>
There are no files in "/opt/ocp-tft" anymore. It is not useful to have that as WORKDIR. Set it to "/" instead. Signed-off-by: Thomas Haller <[email protected]>
This is run for every pull request (against "main"). We want to build the container images, but don't actually push them anywhere. There is no use in tagging those images, especially not with a non-trivial tag like we did. Signed-off-by: Thomas Haller <[email protected]>
Signed-off-by: Thomas Haller <[email protected]>
Let's ignore all directories that end in "*venv/". This also covers the old name "ocp-venv/", which we don't want to see anymore. Signed-off-by: Thomas Haller <[email protected]>
thom311
force-pushed
the
th/ocp-rename
branch
from
703e889 to
667d167
Compare
|
TY For making the refactoring changes. LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the project was renamed, rename also some other names.