Merge pull request #23 from Zinkelburger/remove_tty

Remove unused `-t`
ovn-kubernetes · Apr 25, 2024 · bf4bbb0 · bf4bbb0
2 parents 7a046cd + 44534a9
commit bf4bbb0
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/iperf.py b/iperf.py
@@ -70,7 +70,7 @@ def setup(self):
         else:
             # Create the server pods
             super().setup()
-            cmd = f"exec -t {self.pod_name} -- {IPERF_EXE} -s -p {self.port} --one-off --json"
+            cmd = f"exec {self.pod_name} -- {IPERF_EXE} -s -p {self.port} --one-off --json"
 
         logger.info(f"Running {cmd}")
 
@@ -140,7 +140,7 @@ def client(self, cmd: str) -> Result:
             return self.run_oc(cmd)
 
         server_ip = self.get_target_ip()
-        self.cmd = f"exec -t {self.pod_name} -- {IPERF_EXE} -c {server_ip} -p {self.port} --json -t {duration}"
+        self.cmd = f"exec {self.pod_name} -- {IPERF_EXE} -c {server_ip} -p {self.port} --json -t {duration}"
         if self.test_type == TestType.IPERF_UDP:
             self.cmd = f" {self.cmd} {IPERF_UDP_OPT}"
         if self.reverse:

diff --git a/measureCpu.py b/measureCpu.py
@@ -30,7 +30,7 @@ def stat(self, cmd: str) -> Result:
             return self.run_oc(cmd)
 
         # 1 report at intervals defined by the duration in seconds.
-        self.cmd = f"exec -t {self.pod_name} -- mpstat -P ALL {duration} 1"
+        self.cmd = f"exec {self.pod_name} -- mpstat -P ALL {duration} 1"
         self.exec_thread = ReturnValueThread(target=stat, args=(self, self.cmd))
         self.exec_thread.start()
         logger.info(f"Running {self.cmd}")

diff --git a/measurePower.py b/measurePower.py
@@ -56,7 +56,7 @@ def stat(self, cmd: str, duration: int) -> Result:
             return r
 
         # 1 report at intervals defined by the duration in seconds.
-        self.cmd = f"exec -t {self.pod_name} -- ipmitool dcmi power reading"
+        self.cmd = f"exec {self.pod_name} -- ipmitool dcmi power reading"
         self.exec_thread = ReturnValueThread(
             target=stat, args=(self, self.cmd, duration)
         )