Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin subtask: fix templating instructions (escape hyphens) #55

Merged
merged 1 commit into from
Jan 6, 2020

Conversation

loopfz
Copy link
Member

@loopfz loopfz commented Dec 27, 2019

Fixes #54

@loopfz loopfz force-pushed the fix-subtask-templating branch from aac0086 to 2836f0f Compare December 27, 2019 14:58
@loopfz loopfz added the 👀 NEED REVIEW 👀 Issue or PR need a review label Dec 27, 2019
@loopfz loopfz requested a review from pablito-perez December 27, 2019 15:10
Copy link
Contributor

@w3st3ry w3st3ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

rbeuque74 added a commit that referenced this pull request Jan 6, 2020
Plugin subtask: fix templating instructions (escape hyphens)
@rbeuque74 rbeuque74 merged commit 2836f0f into master Jan 6, 2020
@rbeuque74 rbeuque74 deleted the fix-subtask-templating branch January 6, 2020 09:55
@loopfz loopfz restored the fix-subtask-templating branch January 13, 2020 17:05
@loopfz loopfz deleted the fix-subtask-templating branch March 25, 2020 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👀 NEED REVIEW 👀 Issue or PR need a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

foreach + subtask breaks the templating engine
3 participants