Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add datasource for cloud project private network #723

Merged

Conversation

Galiley
Copy link
Contributor

@Galiley Galiley commented Sep 11, 2024

Description

Add datasource for cloud_project_private_network

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (improve existing resource(s) or datasource(s))
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A: make testacc TESTARGS="-run TestAccDataSourceCloudProjectNetworkPrivate_basic"
  • Test B: make testacc TESTARGS="-run TestAccDataSourceCloudProjectNetworkPrivates_basic"
  • Test C: make testacc TESTARGS="-run TestAccDataSourceCloudProjectNetworkPrivateSubnets_basic"

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings or issues
  • I have added acceptance tests that prove my fix is effective or that my feature works
  • New and existing acceptance tests pass locally with my changes
  • I ran succesfully go mod vendor if I added or modify go.mod file

@Galiley Galiley requested a review from amstuta September 12, 2024 13:51
@Galiley Galiley force-pushed the feat/add_datasource_cloud_project_private_network branch from c98ad3d to e26e882 Compare September 12, 2024 14:13
@amstuta amstuta merged commit 33e8e00 into ovh:master Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants