Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kms): ods18 migration #14544

Merged
merged 6 commits into from
Jan 28, 2025
Merged

feat(kms): ods18 migration #14544

merged 6 commits into from
Jan 28, 2025

Conversation

chipp972
Copy link
Contributor

Question Answer
Branch? develop
Bug fix? no
New feature? yes
Breaking change? no
Tickets MANAGER-15416
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@chipp972 chipp972 requested review from a team as code owners December 11, 2024 17:45
@github-actions github-actions bot added continuous-integration Changes to our CI configuration files and scripts universe-web-cloud dependencies Pull requests that update a dependency file enabler common feature New feature labels Dec 11, 2024
@github-actions github-actions bot removed continuous-integration Changes to our CI configuration files and scripts common labels Dec 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 11, 2024 •
edited
Loading

yarn.lock changes

Summary

Status Count
UPDATED 14
Click to toggle table visibility
Name Status Previous Current
@babel/core UPDATED 7.25.7 7.26.0
@babel/plugin-transform-react-jsx-self UPDATED 7.25.7 7.25.9
@babel/plugin-transform-react-jsx-source UPDATED 7.25.7 7.25.9
@vitejs/plugin-react UPDATED 4.3.3 4.3.4
@vitest/coverage-v8 UPDATED 2.1.5 2.1.8
@vitest/expect UPDATED 2.1.5 2.1.8
@vitest/mocker UPDATED 2.1.5 2.1.8
@vitest/pretty-format UPDATED 2.1.5 2.1.8
@vitest/runner UPDATED 2.1.5 2.1.8
@vitest/snapshot UPDATED 2.1.5 2.1.8
@vitest/spy UPDATED 2.1.5 2.1.8
@vitest/utils UPDATED 2.1.5 2.1.8
vite-node UPDATED 2.1.5 2.1.8
vitest UPDATED 2.1.5 2.1.8

@chipp972 chipp972 changed the title Feat/kms ods18 feat(kms): ods18 migration Dec 12, 2024
@chipp972 chipp972 force-pushed the feat/kms-ods18 branch 7 times, most recently from afec988 to a72f8bf Compare December 13, 2024 17:02
@github-actions github-actions bot added common has conflicts Has conflicts to resolve before merging labels Dec 13, 2024
@rjamet-ovh rjamet-ovh changed the base branch from master to release/kms-ods18 January 28, 2025 15:18
Nicolas Pierre-charles and others added 6 commits January 28, 2025 16:22
feat(kms): ods18 upgrade
7c9adec 
ref: MANAGER-15416

Signed-off-by: Nicolas Pierre-charles <[email protected]>
Signed-off-by: David Arsène <[email protected]>
fix(kms): fix UI post ods18 upgrade
a59bc84 
ref: MANAGER-16501

Signed-off-by: Romain Jamet <[email protected]>
fix(kms): fix credential submit CTA validation
8afe4c4 
ref: MANAGER-16458

Signed-off-by: Romain Jamet <[email protected]>
fix(kms): fix kms tests
cd1d397 
ref: MANAGER-15416

Signed-off-by: Romain Jamet <[email protected]>
fix(kms): use DeleteServiceModal and fix banners
913950a 
ref: MANAGER-16657

Signed-off-by: Romain Jamet <[email protected]>
fix(kms): fix test ods18 bump
701dae6 
ref: MANAGER-15416

Signed-off-by: Romain Jamet <[email protected]>
@github-actions github-actions bot removed the common label Jan 28, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
2.3% Duplication on New Code

See analysis details on SonarQube Cloud

@rjamet-ovh rjamet-ovh mentioned this pull request Jan 28, 2025
Merged
3 tasks
@rjamet-ovh rjamet-ovh merged commit cbc5924 into release/kms-ods18 Jan 28, 2025
13 checks passed
@rjamet-ovh rjamet-ovh deleted the feat/kms-ods18 branch January 28, 2025 16:09
darsene pushed a commit that referenced this pull request Jan 29, 2025
@chipp972 @darsene
feat(kms): ods18 migration (#14544)
11d03ac 
ref: MANAGER-15739

Signed-off-by: Nicolas Pierre-charles <[email protected]>
Co-authored-by: Romain Jamet <[email protected]>
darsene pushed a commit that referenced this pull request Jan 29, 2025
@chipp972 @darsene
feat(kms): ods18 migration (#14544)
5e23f21 
ref: MANAGER-15739

Signed-off-by: Nicolas Pierre-charles <[email protected]>
Co-authored-by: Romain Jamet <[email protected]>
ppprevost pushed a commit that referenced this pull request Feb 12, 2025
@chipp972
feat(kms): ods18 migration (#14544)
11226d3 
ref: MANAGER-15739

Signed-off-by: Nicolas Pierre-charles <[email protected]>
Co-authored-by: Romain Jamet <[email protected]>
ppprevost pushed a commit that referenced this pull request Feb 17, 2025
@chipp972
feat(kms): ods18 migration (#14544)
af64408 
ref: MANAGER-15739

Signed-off-by: Nicolas Pierre-charles <[email protected]>
Co-authored-by: Romain Jamet <[email protected]>
aottr pushed a commit that referenced this pull request Feb 20, 2025
@chipp972 @aottr
feat(kms): ods18 migration (#14544)
d10870d 
ref: MANAGER-15739

Signed-off-by: Nicolas Pierre-charles <[email protected]>
Co-authored-by: Romain Jamet <[email protected]>
ppprevost pushed a commit that referenced this pull request Feb 20, 2025
@chipp972
feat(kms): ods18 migration (#14544)
a6cdfca 
ref: MANAGER-15739

Signed-off-by: Nicolas Pierre-charles <[email protected]>
Co-authored-by: Romain Jamet <[email protected]>
ppprevost pushed a commit that referenced this pull request Feb 20, 2025
@chipp972
feat(kms): ods18 migration (#14544)
fa0a45a 
ref: MANAGER-15739

Signed-off-by: Nicolas Pierre-charles <[email protected]>
Co-authored-by: Romain Jamet <[email protected]>
ppprevost pushed a commit that referenced this pull request Feb 20, 2025
@chipp972
feat(kms): ods18 migration (#14544)
a4ce3b1 
ref: MANAGER-15739

Signed-off-by: Nicolas Pierre-charles <[email protected]>
Co-authored-by: Romain Jamet <[email protected]>
ppprevost pushed a commit that referenced this pull request Feb 20, 2025
@chipp972
feat(kms): ods18 migration (#14544)
f1a83ea 
ref: MANAGER-15739

Signed-off-by: Nicolas Pierre-charles <[email protected]>
Co-authored-by: Romain Jamet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjamet-ovh rjamet-ovh rjamet-ovh left review comments

@darsene darsene darsene approved these changes

@pauldkn pauldkn pauldkn left review comments

@frenautvh frenautvh Awaiting requested review from frenautvh frenautvh was automatically assigned from ovh/su-digital-tools-core-stack

@seven-amid seven-amid Awaiting requested review from seven-amid seven-amid was automatically assigned from ovh/su-digital-tools-core-stack

@MaximeBajeux MaximeBajeux Awaiting requested review from MaximeBajeux MaximeBajeux was automatically assigned from ovh/team-manager-dev-angularjs

@oalkabouss oalkabouss Awaiting requested review from oalkabouss oalkabouss was automatically assigned from ovh/team-manager-dev-angularjs

@mhelhali-soufien mhelhali-soufien Awaiting requested review from mhelhali-soufien mhelhali-soufien was automatically assigned from ovh/team-manager-dev-angularjs

@fredericvilcot fredericvilcot Awaiting requested review from fredericvilcot

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file enabler feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chipp972 @pauldkn @darsene @rjamet-ovh