fix(pci-workflow): optimize performances

Signed-off-by: Simon Chaumet <[email protected]>
ovh · Feb 14, 2025 · 1fbfc15 · 1fbfc15
1 parent 02a1ae6
commit 1fbfc15
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 30 deletions.
diff --git a/packages/manager/apps/pci-workflow/src/api/hooks/order.ts b/packages/manager/apps/pci-workflow/src/api/hooks/order.ts
@@ -24,20 +24,18 @@ export const useProjectSnapshotAddons = (projectId: string) => {
       { data: catalog, isFetching: isCatalogFetching },
       { data: snapshotAvailabilities, isFetching: isPlansFetching },
     ]) => {
-      const snapshotRegionPlans =
-        snapshotAvailabilities?.plans?.filter(({ code }) =>
-          isSnapshotConsumption(code),
-        ) ?? [];
+      const snapshotRegionPlans = new Map(
+        snapshotAvailabilities?.plans
+          ?.filter(({ code }) => isSnapshotConsumption(code))
+          .map(({ code, regions }) => [code, regions]) ?? [],
+      );
 
       return {
         addons: catalog?.addons
-          .filter(({ planCode }) =>
-            snapshotRegionPlans.find((p) => p.code === planCode),
-          )
+          .filter(({ planCode }) => snapshotRegionPlans.has(planCode))
           .map((addon) => ({
             ...addon,
-            regions: snapshotRegionPlans.find((p) => p.code === addon.planCode)
-              .regions,
+            regions: snapshotRegionPlans.get(addon.planCode),
           })),
         isFetching: isCatalogFetching || isPlansFetching,
       };

diff --git a/packages/manager/apps/pci-workflow/src/components/new/ResourceSelector.component.tsx b/packages/manager/apps/pci-workflow/src/components/new/ResourceSelector.component.tsx
@@ -45,27 +45,32 @@ const useDatagridColumn = (
   return [
     {
       id: 'actions',
-      cell: (instance: TWorkflowInstance) => (
-        <div className="text-center">
-          <NotSupportedTooltipComponent
-            supported={regions.includes(instance.region)}
-          >
-            <OsdsRadioButton
-              checked={selectedInstance?.id === instance?.id || undefined}
-              color={ODS_THEME_COLOR_INTENT.primary}
-              size={ODS_RADIO_BUTTON_SIZE.xs}
-              data-testid={`radio-button-${instance.id}`}
-              disabled={!regions.includes(instance.region) || undefined}
-              className="mx-auto"
-              onClick={() => {
-                if (regions.includes(instance.region)) {
-                  onSelectInstance(instance);
-                }
-              }}
-            />
-          </NotSupportedTooltipComponent>
-        </div>
-      ),
+      cell: (instance: TWorkflowInstance) => {
+        const isRegionSupportingAutomaticBackup = regions.includes(
+          instance.region,
+        );
+        return (
+          <div className="text-center">
+            <NotSupportedTooltipComponent
+              supported={isRegionSupportingAutomaticBackup}
+            >
+              <OsdsRadioButton
+                checked={selectedInstance?.id === instance?.id || undefined}
+                color={ODS_THEME_COLOR_INTENT.primary}
+                size={ODS_RADIO_BUTTON_SIZE.xs}
+                data-testid={`radio-button-${instance.id}`}
+                disabled={!isRegionSupportingAutomaticBackup || undefined}
+                className="mx-auto"
+                onClick={() => {
+                  if (isRegionSupportingAutomaticBackup) {
+                    onSelectInstance(instance);
+                  }
+                }}
+              />
+            </NotSupportedTooltipComponent>
+          </div>
+        );
+      },
       label: '',
     },
     {