Fix incorrect games events types #40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Access `overwolf.games.events.onInfoUpdates2` results `info` property was always an empty object. `[key: string]: any;` is a temporary solution until all possibilities are added. I added only [live_client_data](https://overwolf.github.io/docs/api/overwolf-games-events-lol#live_client_data) and [game_info](https://overwolf.github.io/docs/api/overwolf-games-events-lol#matchstate). Can you check if this is correct? In addition, `extends InfoUpdate2[Feature]` gives you the correct type if you previously checked the `Feature` (see screenshots).
Calling `overwolf.games.launchers.events.getInfo(10902, console.log)` (when League Launcher is running) returns and object with `success`, `status` and `res`. Calling the same method with an unknown ID like `overwolf.games.launchers.events.getInfo(999999, console.log)` returns an object with `success`, `status` and `reason`. There is not `error` property, even if TypeScript tells me so. Thus, I removed `extends Result` to remove `error` from the result and added `status` and `reason`. `res` is optional.
|
I updated this request and description due to an invalid typedef. |
|
@eransharv anything I could do to move things forward? |
|
@lmachens sorry for the delay, but this is a PR that I should check carefully as from browsing it, something not looks right. But not sure. I will be available to check it thoroughly at the beginning of next week. |
|
@eransharv did you find time beginning of this week? |
|
@lmachens sorry about the delay. I'm waiting for the result of an internal discussion regarding the game events def file. I don't have an ETA, but it's on the top of my list. So it will not take too long. |
|
@eransharv any update? |
|
@lmachens It's in my schedule for Tomorrow. I will update you by Tomorrow's EOD. Thanks for your patience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request has two commits.
Access
overwolf.games.events.onInfoUpdates2resultsinfoproperty was always an empty object.any;is a temporary solution until all possibilities are added, I already added the available features.live_client_data and game_info should be complete.
Can you check if this is correct?
In addition,
InfoUpdates2Eventvalidates combinations offeatureandinfo. See screenshot:Calling
overwolf.games.launchers.events.getInfo(10902, console.log)(when League Launcher is running) returns and object withsuccess,statusandres.Calling the same method with an unknown ID like
overwolf.games.launchers.events.getInfo(999999, console.log)returns an object withsuccess,statusandreason.There is not
errorproperty, even if TypeScript tells me so.Thus, I removed
extends Resultto removeerrorfrom the result and addedstatusandreason.resis optional.