Fixes issue 65 #67
Open
Fixes issue 65 #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
January 24, 2022 18:31
* made member fields final where possible * converted anonymous inner classes to lambdas * removed a superfluous generic typing
* usage of a deprecated method resolved * overridden method hid @NotNull annotation
* prevent NPE by checking return value of method that can return null
* use !List.isEmpty() instead of List.size() > 0 * removed superfluous generic type arguments * replace anonymous inner classes with lambdas * use String.replace instead of String.replaceAll where suitable * added empty private ctor for utility class * use Collections.singletonList instead of Arrays.asList with single list entry
* added entry to CONTRIBUTORS * updated copyright date range in modified files and NOTICE * bumped plugin version
…to prevent deprecation warnings. * also added some @NotNull to keep interface
|
As this PR still is not merged, I tried to reach out to @ronhitchens by email the last weeks, but no response. Are you there? I really would like to make some progress to this plugin and even convinced my employer to let me work on it but need to clarify some details. |
|
Hi. Yes, I am here, sort of. I'm in Spain and will be driving all day today. I will follow up when I get home tonight. I am not actively maintaining this code currently and I apologize for not being responsive. I would suggest that perhaps I make you a committer on this repo so that you can carry it forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes PluginException about use of deprecated default implementation (#65)