Skip to content
This repository has been archived by the owner on Jan 3, 2023. It is now read-only.

Run commands in a shell #18

Closed
7 tasks done
dylanratcliffe opened this issue Nov 15, 2021 · 0 comments
Closed
7 tasks done

Run commands in a shell #18

dylanratcliffe opened this issue Nov 15, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@dylanratcliffe
Copy link
Member

dylanratcliffe commented Nov 15, 2021

The command source currently runs commands without any shell, this means that things like shell builtins won't work (e.g. echo). It also means that the environment won't be loaded in the way that users expect and things like additions to the $PATH might be missing.

Commands should be run within a shell by default (bash on Linux and powershell on windows).

Questions

Should users be able to specify the shell?

Maybe, since each shell will need its own arguments though (especially on windows) this won't be able to be completely dynamic, probably more like an approved list

What options should be exposed around shell customisations?

  • Working directory
  • STDIN
  • Environment variables (Make sure these are appended and that we don't remove any environment variables we might otherwise need)
  • Timeout
  • User to run as

Tasks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant