You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 3, 2023. It is now read-only.
The command source currently runs commands without any shell, this means that things like shell builtins won't work (e.g. echo). It also means that the environment won't be loaded in the way that users expect and things like additions to the $PATH might be missing.
Commands should be run within a shell by default (bash on Linux and powershell on windows).
Questions
Should users be able to specify the shell?
Maybe, since each shell will need its own arguments though (especially on windows) this won't be able to be completely dynamic, probably more like an approved list
What options should be exposed around shell customisations?
Working directory
STDIN
Environment variables (Make sure these are appended and that we don't remove any environment variables we might otherwise need)
Timeout
User to run as
Tasks
Work out how Golang is going to deal with the encoding of the text that we return. Is this going to be a problem?
The
command
source currently runs commands without any shell, this means that things like shell builtins won't work (e.g.echo
). It also means that the environment won't be loaded in the way that users expect and things like additions to the $PATH might be missing.Commands should be run within a shell by default (bash on Linux and powershell on windows).
Questions
Should users be able to specify the shell?
Maybe, since each shell will need its own arguments though (especially on windows) this won't be able to be completely dynamic, probably more like an approved list
What options should be exposed around shell customisations?
Tasks
The text was updated successfully, but these errors were encountered: