Adds Arbitrum's sequencer healthy check. #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EperezOk
approved these changes
Feb 15, 2024
| * @return True if the SequencerOracle is up and the grace period passed, false otherwise | ||
| */ | ||
| function isUpAndGracePeriodPassed() external view returns (bool) { | ||
| (, int256 answer,, uint256 lastUpdateTimestamp,) = sequencerOracle.latestRoundData(); |
There was a problem hiding this comment.
Here we are using the lastUpdatedTimestamp field (timestamp of when the round was updated), which is what AAVE is doing as well.
However, in the Chainlink docs, the startedAt (timestamp of when the round started) timestamp is used instead.
I think both implementations should be correct.
There was a problem hiding this comment.
From ArbitrumSequencerUptimeFeed.sol - latestRoundData() we see that both variables are actually the same.
Conceptually, we should use the one that's higher.
TomasCImach
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by AAVE's solution.
Sequencer Oracle in Arbitrum Mainnet
closes #179