Remove edx-platform custom settings and openedx Docker entrypoint and thus fix k8s exec commands
#640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regisb
force-pushed
the
regisb/plugin-v1
branch
4 times, most recently
from
266e70e to
0e02395
Compare
regisb
force-pushed
the
regisb/no-custom-settings
branch
from
0cdff96 to
7a80a58
Compare
regisb
force-pushed
the
regisb/plugin-v1
branch
2 times, most recently
from
2dd1dee to
e17caf9
Compare
regisb
force-pushed
the
regisb/plugin-v1
branch
5 times, most recently
from
eaac298 to
42c206a
Compare
regisb
force-pushed
the
regisb/no-custom-settings
branch
from
7a80a58 to
9934003
Compare
regisb
force-pushed
the
regisb/plugin-v1
branch
3 times, most recently
from
a0fc927 to
cd905cb
Compare
regisb
force-pushed
the
regisb/no-custom-settings
branch
from
9934003 to
7bb640c
Compare
regisb
changed the title
k8s exec commands
Previously, it was possible to override settings by defining the TUTOR_EDX_PLATFORM_SETTINGS environment variable. But let's face it: - It was not very well supported. - It was poorly explained. - It was not very useful. - It causes unnecessary code complexity. For these reasons, we drop that feature.
The entrypoint in the "openedx" Docker image was used only to define the DJANGO_SETTINGS_MODULE environment variable, based on SERVICE_VARIANT and SETTINGS. We ditch SETTINGS in favour of defining explicitely DJANGO_SETTINGS_MODULE. The problem with the Docker entrypoint is that it was bypassed whenever we ran `tutor local exec` or `tutor k8s exec`. By removing it we make it simpler for end-users to run manage.py commands in kubernetes.
regisb
force-pushed
the
regisb/no-custom-settings
branch
from
7bb640c to
9bd809d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.