feat: run tutor k8s exec ... commands with multiple args
#637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is ready for review @overhangio/tutor-developers. cc @kdmccormick. |
kdmccormick
approved these changes
Apr 12, 2022
There was a problem hiding this comment.
LGTM, with a couple notes:
- The workaround to this issue that I had been using was to to wrap the command and its args in quotes, e.g.
tutor k8s exec "ls -l". This PR "breaks" that workaround (which is totally fine with me), but consider marking it a breaking change in the changelog. Up to you. - #636 raises two issues. This PR solves one of them, but the second issue (
DJANGO_DEBUG_TOOLBARnot being set) still exists, and is a problem fortutor [dev|local] execas well. I think we should open a new issue to track it. I had proposed a potential solution in this comment.
Previously, the `k8s exec` command did not support unknown "--options". This made it impossible to launch, say, a django shell in the lms container. While implementing this feature we saw an opportunity to simplify the way jobs are handled in the k8s commands. Close #636. Another related issue is: openedx-unsupported/wg-developer-experience#52
|
Good points @kdmccormick. I modified the changelog to indicate a breaking change. Indeed, this in itself does not resolve the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
k8s execcommand did not support unknown "--options". Thismade it impossible to launch, say, a django shell in the lms container.
While implementing this feature we saw an opportunity to simplify the way jobs
are handled in the k8s commands.
Close #636.
Another related issue is: openedx-unsupported/wg-developer-experience#52