Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BrowsableAPIRenderer in production #34

Closed
CodeWithEmad opened this issue Feb 27, 2024 · 0 comments
Closed

BrowsableAPIRenderer in production #34

CodeWithEmad opened this issue Feb 27, 2024 · 0 comments

Comments

@CodeWithEmad
Copy link
Member

Having a browsable API is not necessarily a bad thing, but since this is an API Server, and there are no static files, shouldn't we replace that with JSONRenderer?

Screenshot from 2024-02-27 17-02-04

I'm aware of the notes-settings patch, but I think this should be handled by the plugin.
CodeWithEmad added a commit to CodeWithEmad/tutor-notes that referenced this issue Feb 27, 2024
@CodeWithEmad
fix: set JSONRenderer as the DEFAULT_RENDERER_CLASSES
93adf14 
in production environments, it's not the best practice to have a browsable API and normally only a json should be returned.

Close overhangio#34
@CodeWithEmad CodeWithEmad mentioned this issue Feb 27, 2024
Closed
CodeWithEmad added a commit to CodeWithEmad/tutor-notes that referenced this issue Mar 11, 2024
@CodeWithEmad
fix: set JSONRenderer as the DEFAULT_RENDERER_CLASSES
c52eb18 
in production environments, it's not the best practice to have a browsable API and normally only a json should be returned.

Close overhangio#34
@DawoudSheraz DawoudSheraz moved this from Pending Triage to In Progress in Tutor project management Mar 12, 2024
@DawoudSheraz DawoudSheraz moved this from In Progress to Backlog in Tutor project management Mar 12, 2024
@DawoudSheraz DawoudSheraz moved this from Backlog to In review in Tutor project management Apr 3, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in Tutor project management Apr 22, 2024
@DawoudSheraz DawoudSheraz moved this from Done to Won't fix in Tutor project management Apr 29, 2024
@DawoudSheraz DawoudSheraz closed this as not planned Won't fix, can't repro, duplicate, stale Apr 29, 2024
@github-project-automation github-project-automation bot moved this from Won't fix to Done in Tutor project management Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Tutor project management
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: set JSONRenderer as the DEFAULT_RENDERER_CLASSES CodeWithEmad/tutor-notes
2 participants
@DawoudSheraz @CodeWithEmad