Feat: Upgrade clickhouse server docker image #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| RENAME TABLE _openedx_user_profiles TO openedx_user_profiles; | ||
| RENAME TABLE _openedx_users TO openedx_users; | ||
|
|
||
| DROP TABLE course_enrollments; |
There was a problem hiding this comment.
why do we need to drop the table here? Shouldn't it be view (considering view is being created right after that)?
There was a problem hiding this comment.
Table is already created using Live View command, that's why we need to drop it.
|
|
||
| # The clickhouse repo is currently unavailable in some parts of the world. If we don't | ||
| # remove this repo here then `apt update` will fail. Check if the problem is resolved with: | ||
| # curl https://repo.yandex.ru/clickhouse/deb/stable/ | ||
| # The above command should be a 200, and not a 404. | ||
| RUN rm /etc/apt/sources.list.d/clickhouse.list | ||
| # RUN rm /etc/apt/sources.list.d/clickhouse.list |
There was a problem hiding this comment.
nit: remove this if it is not needed.
DawoudSheraz
reviewed
May 6, 2024
| openedx_user_profiles.country AS user_country | ||
| FROM openedx_course_enrollments | ||
| INNER JOIN openedx_user_profiles ON openedx_course_enrollments.user_id = openedx_user_profiles.user_id | ||
| INNER JOIN openedx_users ON openedx_course_enrollments.user_id = openedx_users.id; |
There was a problem hiding this comment.
nit: end of file line missing
DawoudSheraz
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #30
Upgrade clickhouse docker image and fix query issues due to deprecation of Live views.
We currently have 2 live views course_enrollments & course_block_completion. After upgrading clickhouse version, we encountered errors due to deprecation of live views.
After transitioning from live views to normal views to resolve the issue, we encountered a new challenge:
course_enrollment&course_block_completiontables are only accessible in main db(openedx) and we get error on staff specified db’s. It's because staff user's don't have access to the tables that view statement is utilizing(_openedx_course_enrollments,_openedx_user_profiles&_openedx_usersetc).To resolve this, we've extended access to these tables for staff users and updated the corresponding row policy. This decision is backed by the fact that the live view already displays data from these tables through join operations.