-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extensibility for easy integration of Apollo Federation PHP (v2) #1040
base: 0.14
Are you sure you want to change the base?
Add extensibility for easy integration of Apollo Federation PHP (v2) #1040
Conversation
For further simplifying of dependency injection
For further simplifying of dependency injection
c51b2d9
to
515f86f
Compare
c3e8bf1
to
cf99c9b
Compare
Hi @Aeliot-Tm !
|
This is something we would need. Let me know if I can help. |
@nicholasruunu FYI: |
The main aim of changes was to make package more flexible for extending by other packages. Now I work on implementation of Apollo Federation PHP (v2) and integration of it into several projects.
I saw updates with the same purposes by @Vincz (https://github.com/vincz/GraphQLBundle). But if understand correct he propose to copy-paste same configuration to the several bundles/packages what is not good on my point of view.
I would be very glad to get review of this PR by community.
BS Breaks:
There is a list of BC breaks. Even property of protected method became nullable it is listed here.
\Overblog\GraphQLBundle\Config\TypeDefinition::getName()
.\Overblog\GraphQLBundle\Config\Parser\GraphQL\ASTConverter\DescriptionNode::toConfig()
return empty array when parseGraphQL\Language\AST\TypeExtensionNode
.$query
of the method\Overblog\GraphQLBundle\Definition\Builder\SchemaBuilder::buildSchemaArguments()
can be nullable.\Overblog\GraphQLBundle\Generator\TypeBuilder()
. It is split on several services.Deprecations
\Overblog\GraphQLBundle\Generator\Collection
and\Overblog\GraphQLBundle\Generator\TypeGeneratorOptions
moved to..\Model
namespace but created stub classes for the backward compatibility which should be removed later.