New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Bun.serve: error: pass Request parameter when available" #9332

Merged

Jarred-Sumner merged 1 commit into main from revert-9310-nektro-patch-36472

Mar 9, 2024

Collaborator

Jarred-Sumner commented Mar 9, 2024

Reverts #9310

Causes test failures on all non-Windows platforms. I should've waited longer before pressing merge.


          Revert "Bun.serve: error: pass Request parameter when available (#9310)"

a01f00f

This reverts commit b92d985.

Jarred-Sumner merged commit 79e77f1 into main

18 of 19 checks passed

Jarred-Sumner deleted the revert-9310-nektro-patch-36472 branch

March 9, 2024 16:44

Contributor

github-actions bot commented Mar 9, 2024

❌ @Jarred-Sumner 1 files with test failures on linux-x64-baseline:

test/js/third_party/prisma/prisma.test.ts 1 failing

View test output

^{#6cb19c10116ea2c89400938250fe0d56d676c3d3}

Contributor

github-actions bot commented Mar 9, 2024

❌ @Jarred-Sumner 2 files with test failures on linux-x64:

test/js/node/watch/fs.watchFile.test.ts 1 failing
test/js/third_party/prisma/prisma.test.ts 1 failing

View test output

^{#6cb19c10116ea2c89400938250fe0d56d676c3d3}

Contributor

github-actions bot commented Mar 9, 2024

❌ @Jarred-Sumner 3 files with test failures on bun-darwin-aarch64:

test/integration/next/default-pages-dir/test/next-build.test.ts SIGTERM
test/js/node/watch/fs.watchFile.test.ts 2 failing
test/js/third_party/prisma/prisma.test.ts 2 failing

View test output

^{#6cb19c10116ea2c89400938250fe0d56d676c3d3}

Contributor

github-actions bot commented Mar 9, 2024

❌ @Jarred-Sumner 2 files with test failures on bun-darwin-x64:

test/js/third_party/jsonwebtoken/claim-aud.test.js 1 failing
test/js/third_party/prisma/prisma.test.ts 2 failing

View test output

^{#6cb19c10116ea2c89400938250fe0d56d676c3d3}

Contributor

github-actions bot commented Mar 9, 2024

❌🪟 @Jarred-Sumner, there are 17 test regressions on Windows x86_64

test\cli\install\bun-upgrade.test.ts
test\cli\install\migration\migrate.test.ts
test\cli\run\run-eval.test.ts
test\cli\run\transpiler-cache.test.ts
test\js\bun\dns\resolve-dns.test.ts
test\js\bun\http\fetch-file-upload.test.ts
test\js\bun\http\bun-server.test.ts
test\js\bun\shell\shelloutput.test.ts
test\js\bun\shell\throw.test.ts
test\js\node\dns\node-dns.test.js
test\js\node\process\process-args.test.js
test\js\third_party\es-module-lexer\es-module-lexer.test.ts
test\js\web\fetch\body-stream-excess.test.ts
test\js\web\fetch\body-stream.test.ts
test\js\web\timers\performance.test.js
test\js\web\websocket\websocket.test.js
test\js\web\workers\worker.test.ts

Full Test Output

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet