fix: #7932

[eriklangille]

What does this PR do?

Fixes #7932

When updating a package that is used as a peerDependency in one of the installed packages, then old package would be kept as a module within the child package's node_modules. With this fix, the child package uses the root package, as expected.

• Documentation or TypeScript types (it's okay to leave the rest blank in this case)
• Code changes

How did you verify your code works?

I wrote automated tests

• I checked the lifetime of memory allocated to verify it's (1) freed and (2) only freed when it should be
• I included a test for the new code, or an existing test covers it
• JSValue used outside outside of the stack is either wrapped in a JSC.Strong or is JSValueProtect'ed
• I wrote TypeScript/JavaScript tests and they pass locally (bun-debug test test/cli/install/registry/bun-install-registry.test.ts)

[dylan-conway]

This is great. This also fixes a todo test in bun-install-registry.test.ts. If you search for the test it should install in such a way that two identical packages with different peer dependencies are different instances, remove the todo, and change expect(out).toBe("true\ntrue\ntrue\n"); to expect(out).toBe("true\ntrue\nfalse\n");, it should pass. Testing manually with yarn and npm shows that the last boolean in the string should actually be false.

[eriklangille]

This is great. This also fixes a todo test in bun-install-registry.test.ts. If you search for the test it should install in such a way that two identical packages with different peer dependencies are different instances, remove the todo, and change expect(out).toBe("true\ntrue\ntrue\n"); to expect(out).toBe("true\ntrue\nfalse\n");, it should pass. Testing manually with yarn and npm shows that the last boolean in the string should actually be false.

Done.

[dylan-conway]

Thank you