Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to std.sort.pdq from std.sort.block #7574

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Switch to std.sort.pdq from std.sort.block #7574

merged 1 commit into from
Dec 11, 2023

Conversation

Jarred-Sumner
Copy link
Collaborator

What does this PR do?

Switch from std.sort.block to std.sort.pdq, which is an unstable sorting algorithm. The implementation of block sort did not support values being equal, so I don't think there will be a behavior difference other than the workaround for bun install

See ziglang/zig#18252

How did you verify your code works?

Existing tests should have interesting things to say if this causes other bugs

Copy link
Contributor

@Jarred-Sumner 4 files with test failures on bun-darwin-aarch64:

  • test/cli/install/bunx.test.ts
  • test/cli/run/env.test.ts
  • test/cli/run/require-cache.test.ts
  • test/integration/next/default-pages-dir/test/next-build.test.ts

View test output

#abfdd14b196e20995fd7bca73182ff47012c7376

Copy link
Contributor

@Jarred-Sumner 2 files with test failures on linux-x64-baseline:

  • test/cli/run/env.test.ts
  • test/integration/next/default-pages-dir/test/next-build.test.ts

View test output

#abfdd14b196e20995fd7bca73182ff47012c7376

Copy link
Contributor

@Jarred-Sumner 2 files with test failures on linux-x64:

  • test/cli/run/env.test.ts
  • test/integration/next/default-pages-dir/test/next-build.test.ts

View test output

#abfdd14b196e20995fd7bca73182ff47012c7376

Copy link
Contributor

@Jarred-Sumner 8 files with test failures on bun-darwin-x64:

  • test/cli/run/env.test.ts
  • test/integration/next/default-pages-dir/test/next-build.test.ts
  • test/js/bun/spawn/spawn-streaming-stdout.test.ts
  • test/js/bun/util/filesink.test.ts
  • test/js/bun/util/which.test.ts
  • test/js/node/fs/fs.test.ts
  • test/js/third_party/webpack/webpack.test.ts
  • test/js/web/timers/setTimeout.test.js

View test output

#abfdd14b196e20995fd7bca73182ff47012c7376

Copy link
Contributor

@Jarred-Sumner 8 files with test failures on bun-darwin-x64-baseline:

  • test/cli/run/env.test.ts
  • test/integration/next/default-pages-dir/test/next-build.test.ts
  • test/js/bun/util/filesink.test.ts
  • test/js/bun/util/which.test.ts
  • test/js/node/fs/fs.test.ts
  • test/js/node/watch/fs.watchFile.test.ts
  • test/js/third_party/webpack/webpack.test.ts
  • test/js/web/timers/setTimeout.test.js

View test output

#abfdd14b196e20995fd7bca73182ff47012c7376

@Jarred-Sumner Jarred-Sumner merged commit 351810e into main Dec 11, 2023
18 of 28 checks passed
@Jarred-Sumner Jarred-Sumner deleted the jarred/sort branch December 11, 2023 03:49
ryoppippi pushed a commit to ryoppippi/bun that referenced this pull request Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant