Switch to std.sort.pdq
from std.sort.block
#7574
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Switch from
std.sort.block
tostd.sort.pdq
, which is an unstable sorting algorithm. The implementation of block sort did not support values being equal, so I don't think there will be a behavior difference other than the workaround for bun installSee ziglang/zig#18252
How did you verify your code works?
Existing tests should have interesting things to say if this causes other bugs