Fix running Bun.spawn on Vercel and GCP
#6724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jarred-Sumner
commented
Oct 26, 2023
| @@ -476,11 +476,23 @@ pub fn scoped(comptime tag: @Type(.EnumLiteral), comptime disabled: bool) _log_f | |||
| defer lock.unlock(); | |||
|
|
|||
| if (Output.enable_ansi_colors_stderr) { | |||
| out.print(comptime prettyFmt("<r><d>[" ++ @tagName(tag) ++ "]<r> " ++ fmt, true), args) catch unreachable; | |||
| buffered_writer.flush() catch unreachable; | |||
| out.print(comptime prettyFmt("<r><d>[" ++ @tagName(tag) ++ "]<r> " ++ fmt, true), args) catch { | |||
There was a problem hiding this comment.
this was to silence debug logs from throwing "PipeError"
paperclover
reviewed
Oct 26, 2023
| } | ||
|
|
||
| pub fn shouldUseWaiterThread() bool { | ||
| return @atomicLoad(bool, &should_use_waiter_thread, .Monotonic); |
There was a problem hiding this comment.
should be fine but why not use std.atomic and/or atomic store when setting
|
❌ @Jarred-Sumner 2 files with test failures on linux-x64-baseline:
|
|
❌ @Jarred-Sumner 2 files with test failures on linux-x64:
|
|
❌ @Jarred-Sumner 5 files with test failures on bun-darwin-aarch64:
|
|
❌ @Jarred-Sumner 6 files with test failures on bun-darwin-x64-baseline:
|
|
❌ @Jarred-Sumner 4 files with test failures on bun-darwin-x64:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
pidfd_openis not implemented by gVisor and by older Linux kernels. This implements a workaround where we spawn a thread, enqueue concurrent tasks and callwaitpidon eachSubprocess'spid. This workaround is very loosely based on libuv's default behavior.Fixes #5803
Need to manually test that it does indeed fix the issue, but it should
How did you verify your code works?
I tested manually + added a hidden environment variable to let us manually enable this for testing purposes