Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conflicts with @types/node in bun-types #17424

Draft
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

alii
Copy link
Collaborator

@alii alii commented Feb 18, 2025

What does this PR do?

This is a WIP PR improving on the conflicts that @types/bun has with @types/node. It also fixes the ShellError export that the types claim exists, but actually doesn't.

Addresses #15481 #8761 #13864

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes (only minor)

How did you verify your code works?

There's now an integration test for TypeScript which uses the local bun-types and pretends to be a real test case.

@alii alii added typescript Something for TypeScript ecosystem Something that relates to package or framework compatibility build An issue related to building or compiling types An issue with TypeScript types labels Feb 18, 2025
@robobun
Copy link

robobun commented Feb 18, 2025

Updated 5:10 PM PT - Feb 19th, 2025

@alii, your commit 4025ca4 has 3 failures in Build #11853:


🧪   try this PR locally:

bunx bun-pr 17424

@alii alii mentioned this pull request Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build An issue related to building or compiling ecosystem Something that relates to package or framework compatibility types An issue with TypeScript types typescript Something for TypeScript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants