Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: bump pglite version #17117

Merged
merged 1 commit into from
Feb 6, 2025
Merged

test: bump pglite version #17117

merged 1 commit into from
Feb 6, 2025

Conversation

190n
Copy link
Contributor

@190n 190n commented Feb 6, 2025

What does this PR do?

Bumps the version of PGlite we test from 0.2.15 to 0.2.16. This test was introduced in #16188 because older versions of the IPInt Wasm interpreter had errors with PGlite ("Out of bounds memory access"). But it turns out 0.2.15 had another issue ("Out of bounds call_indirect") that affects (at least on macOS aarch64) all versions of Bun I've tried, regardless of the Wasm backend used (more discussion at electric-sql/pglite#486).

I'm still investigating why this test had not been failing in CI.

How did you verify your code works?

Ran the new PGlite test.

@robobun
Copy link

robobun commented Feb 6, 2025

Updated 12:43 PM PT - Feb 6th, 2025

@190n, your commit 15f44c1 has 2 failures in Build #11207:


🧪   try this PR locally:

bunx bun-pr 17117

@Jarred-Sumner Jarred-Sumner merged commit 4d2a865 into main Feb 6, 2025
66 of 69 checks passed
@Jarred-Sumner Jarred-Sumner deleted the ben/bump-pglite branch February 6, 2025 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants