-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix bunx
on windows with postinstall scripts
#17076
Conversation
Updated 9:40 PM PT - Feb 5th, 2025
❌ @RiskyMH, your commit 5fe203d has 1 failures in
🧪 try this PR locally: bunx bun-pr 17076 |
bunx
on windows and its postinstall scriptingbunx
on windows with postinstall scripts
Maybe there should be some test for this? |
Yeah i will. Just investigating more rn. Also going to sleep soon, but I wanted to find the cause of this as it was buging me. Seems simple to add test though, im surprised it hasn't failed anything already but the tests probably don't have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. @paperclover should take a look too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great find
fixes #9841
fixes #15783, fixes #15562, fixes #14848, fixes #12336, fixes #10068
context behind change is it runs
<current-exe> exec
on windows which would bebunx exec
but as that subcommand wasn't resolvable it just tried to runexec
as a package:bun/src/install/lifecycle_script_runner.zig
Lines 166 to 176 in 1ccc13e
will try to add tests which fail without this