Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bun.lock formatting of bin #17041

Merged
merged 7 commits into from
Feb 5, 2025
Merged

Conversation

dylan-conway
Copy link
Member

What does this PR do?

bin was missing a newline, causing weird formatting. Also adds a space between value and key for cpu and os, which was removed accidentally (only in canary).

How did you verify your code works?

Added a test that snapshots most things the lockfile formatter will print.

@robobun
Copy link

robobun commented Feb 4, 2025

Updated 4:44 PM PT - Feb 4th, 2025

@dylan-conway, your commit b5dd9f2 has 3 failures in Build #11093:


🧪   try this PR locally:

bunx bun-pr 17041

src/install/bun.lock.zig Outdated Show resolved Hide resolved
src/install/bun.lock.zig Outdated Show resolved Hide resolved
src/install/install.zig Outdated Show resolved Hide resolved
@dylan-conway
Copy link
Member Author

Updated

@Jarred-Sumner Jarred-Sumner merged commit 4d004b9 into main Feb 5, 2025
66 of 69 checks passed
@Jarred-Sumner Jarred-Sumner deleted the dylan/fix-bun-lock-formatting branch February 5, 2025 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants