Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement DNS module #1691

Merged
merged 22 commits into from
Jan 7, 2023
Merged

Implement DNS module #1691

merged 22 commits into from
Jan 7, 2023

Conversation

Jarred-Sumner
Copy link
Collaborator

@Jarred-Sumner Jarred-Sumner commented Dec 31, 2022

TODO:

  • lookup function on macOS
  • resolve function on macOS
  • reverse function on macOS
  • lookup function on Linux
  • resolve function on Linux
  • reverse function on Linux
  • Implement node:dns wrapper
  • Decide on Bun.dns, bun:dns or otherwise what the API should be (cc @colinhacks who should probably make the decision)

Probably will ship once just lookup is done on Linux and macOS.

on macOS, we are using dnssd which is a builtin macOS library for multi-cast DNS. There is also an open-source version which can be used on Linux. We could use that.

@Jarred-Sumner
Copy link
Collaborator Author

Update: using dnssd seems like a no-go. DNSServiceGetAddrInfo takes around 10 seconds to timeout when the address is invalid and there is no way to set a timeout

Instead, I think we should try an approach like libuv/libuv#3509

@Jarred-Sumner Jarred-Sumner marked this pull request as ready for review January 7, 2023 15:09
@Jarred-Sumner Jarred-Sumner merged commit 8798346 into main Jan 7, 2023
@Jarred-Sumner Jarred-Sumner deleted the jarred/dns-sd branch January 7, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant