-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement DNS module #1691
Merged
Merged
Implement DNS module #1691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update: using dnssd seems like a no-go. Instead, I think we should try an approach like libuv/libuv#3509 |
fed981f
to
63810c4
Compare
60c205f
to
42e40c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
lookup
function on macOSresolve
function on macOSreverse
function on macOSlookup
function on Linuxresolve
function on Linuxreverse
function on Linuxnode:dns
wrapperBun.dns
,bun:dns
or otherwise what the API should be (cc @colinhacks who should probably make the decision)Probably will ship once just lookup is done on Linux and macOS.
on macOS, we are using
dnssd
which is a builtin macOS library for multi-cast DNS. There is also an open-source version which can be used on Linux. We could use that.