Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zig: update to 0.14.0-dev #16862

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

zig: update to 0.14.0-dev #16862

wants to merge 24 commits into from

Conversation

@robobun
Copy link

robobun commented Jan 29, 2025

Updated 12:32 AM PT - Jan 31st, 2025

@nektro, your commit fd994e5 has 2 failures in Build #10905:


🧪   try this PR locally:

bunx bun-pr 16862

@nektro nektro changed the title zig: update to 0.14.0-dev.2851+b074fb7dd zig: update to 0.14.0-dev.2851+b074fb7dd [wip] Jan 29, 2025
@@ -524,63 +524,54 @@ pub const AspectRatio = struct {
};

pub const BackgroundProperty = packed struct(u16) {
@"background-color": bool = false,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's clearer to keep it as the exact CSS property name. Instead of having to mentally ask "is it background-color or is it color?

Copy link
Member Author

@nektro nektro Jan 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i presumed that was clear since it was on BackgroundProperty and i needed the fields to not interfere with the decl shorthands which are used heavily and do match the name of the respective property

src/bun.zig Outdated Show resolved Hide resolved
@nektro nektro changed the title zig: update to 0.14.0-dev.2851+b074fb7dd [wip] zig: update to 0.14.0-dev [wip] Jan 29, 2025
@paperclover
Copy link
Member

what is the upgrade path for @fence?

after looking through them, i suspect most can be removed without additional changes. some need to change related atomic accesses (see ziglang/zig#21585)

@nektro nektro changed the title zig: update to 0.14.0-dev [wip] zig: update to 0.14.0-dev Jan 30, 2025
@nektro nektro marked this pull request as ready for review January 31, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants