-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
load local bunfig.toml
for bun run
earlier (for run.bun
option)
#16664
base: main
Are you sure you want to change the base?
Conversation
Updated 6:26 PM PT - Jan 27th, 2025
❌ @RiskyMH, your commit 1d12245 has 1 failures in
🧪 try this PR locally: bunx bun-pr 16664 |
bunfig.toml
for bun run
bunfig.toml
for bun run
(for run.bun
option)
bunfig.toml
for bun run
(for run.bun
option)bunfig.toml
for bun run
earlier (for run.bun
option)
Should add a test that shows what this affects and makes sure it doesn't regress |
Done, I think my 3 cases should be appropriate:
The second one could in theory be changed, but I am trying not have any perf change this time (and be minimal changes). |
Alternative to #15596 where it now only impacts
bun run
for the same cwd dir. This does not effectbunx
(even though according to code it should load it), and isnt as fancy asbun install
where it ensures to check the bunfig inpackage.json
dir.This shouldn't have any performance issues because its already loading the file, but now its loading earlier so it can use
run.bun
option.Fixes #11445, (as well as fixes #15484, fixes #15483)