fix(js): better error messages when makeSafe fails #16263
Closed
+118
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonIsaac
requested review from
a team and
paperclover
and removed request for
a team
|
We should just delete these wrappers and instead make JSC have private symbols for what we need these wrappers are a skill issue |
|
see #16259 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Partial redress of opal/opal#2706. Related to #16259.
makeSafecan fail when creating safe iterables if users modify the prototype ofSetorMapbefore primordials are loaded. This PR adds a better error message for such cases, but does nothing to address the underlying problem. We still need to decide on the best course of action there.How did you verify your code works?
I've added tests.